Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert resource map to Drupal Entity API #4027

Merged
merged 46 commits into from Feb 5, 2024
Merged

Convert resource map to Drupal Entity API #4027

merged 46 commits into from Feb 5, 2024

Conversation

paul-m
Copy link
Contributor

@paul-m paul-m commented Sep 24, 2023 •
edited

  • Creates a full-fledged resource mapping db table as a content entity: ResourceMapping.
    • All the columns in the current mapping schema are defined as base fields (that is, non-attached fields).
    • The table name is the same as the current abstract table implementation: dkan_metastore_resource_mapper
  • Adapt DataResource, Referencer, and ResourceMapper to use the ResourceMapping entity.
  • Add and update tests.

(internal: 17017)

@paul-m
compat layer for drupal entities
a6e7940
@paul-m
Merge branch '2.x' into entity-abstract-database
fdb96ef
@paul-m
mapper
b03a685
@paul-m
more entity change
ba4247e
@paul-m
resourcemapper refactored
3c1c39b
@paul-m
still failing against testResourcePurgeDraft
de6819f
@paul-m
ouch I lost the work
4762a21
@paul-m
passing...........
269af2c
@paul-m
Merge branch '2.x' into entity-abstract-database
7d94c52
@paul-m
removed some cruft
35366d3
@paul-m
update hook, cs changes
36d5884
@paul-m
removed form
969afd5
@paul-m
handy view, cs
3090410
@paul-m
remove view config
bd2ea9a
@paul-m
Merge branch '2.x' into entity-resource-mapping
273b883
@paul-m
no more jsonserializable
eb470d6
@paul-m
Merge branch '2.x' into entity-resource-mapping
50eb803
@paul-m
Merge branch '2.x' into entity-resource-mapping
3f19925
@paul-m
Merge branch '2.x' into entity-resource-mapping
29fa209
@paul-m
Merge branch '2.x' into entity-resource-mapping
181dd76
@paul-m
starting a test conversion
2399611
@paul-m
minor
b0d0899
@paul-m
Merge branch '2.x' into entity-resource-mapping
dcf1e37
@paul-m
some test tweaks
2e8ebc4
@paul-m
Merge branch '2.x' into entity-resource-mapping
a46f173
@paul-m
minor
62c58da
@paul-m
stopped half way through fixing tests
1154269
@janette janette added the 2.17 label Dec 29, 2023
@paul-m paul-m marked this pull request as ready for review January 11, 2024 16:50
@dafeder dafeder self-requested a review January 26, 2024 18:54
@paul-m
Copy link
Contributor Author

paul-m commented Feb 1, 2024

Maybe we should add the content add/edit/delete niceties given the existence of #3824

dafeder
dafeder reviewed Feb 2, 2024
View reviewed changes
Copy link
Member

@dafeder dafeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions for more explanatory code comments

modules/metastore/src/Entity/ResourceMapping.php Show resolved Hide resolved
modules/metastore/src/ResourceMapper.php Show resolved Hide resolved
@dafeder dafeder merged commit a34c2ab into 2.x Feb 5, 2024
13 checks passed
@dafeder dafeder deleted the entity-resource-mapping branch February 5, 2024 18:59
@paul-m paul-m mentioned this pull request Feb 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dafeder dafeder dafeder approved these changes

Assignees
No one assigned
Labels
2.17
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@paul-m @dafeder @janette