Use consistent naming conventions #4032
Conversation
| @@ -89,7 +89,7 @@ public function buildForm(array $form, FormStateInterface $form_state) { | |||
|
|
|||
| $form['html_allowed_properties'] = [ | |||
| '#type' => 'checkboxes', | |||
| '#title' => $this->t('Properties that allow HTML'), | |||
| '#title' => $this->t('Dataset properties that allow HTML'), | |||
There was a problem hiding this comment.
Do we consider distribution properties other referenced entity properties also dataset properties? That was the reason I used just "properties"
There was a problem hiding this comment.
Why are we listing every property, most of these should never have html allowed.
There was a problem hiding this comment.
We actually aren't listing every property - only string properties. But DKAN prides itself on swappable schemas, so we cannot hardcode assumptions about what the properties are.
There was a problem hiding this comment.
Not suggesting we hardcode anything, just be more specific where html could be useful. Can this config be put into the *.ui.json files?
There was a problem hiding this comment.
@janette that's an interesting idea. The thing is this would apply for harvests and API posts as well, so it's not exactly intuitive that such config would live in the ui schema... but in theory we could check it and allow HTML in any text area fields, or add a property to the UI schema like allowHTML. Hmmm....
There was a problem hiding this comment.
I would say this would be a different ticket; the one I was working stored the configuration as a Drupal configuration setting. You could re-write it to be part of the schema, but as Dan said it would need to work for harvests and API posts which don't really use the ui schema.
There was a problem hiding this comment.
Yeah. And I think "dataset" is appropriate here, we are showing the dataset and including other schemas within it but they are all really experienced as part of the dataset tree.
| @@ -27,4 +27,4 @@ metastore.data_dictionary.settings_form: | |||
| description: Data-Dictionary Settings | |||
| parent: metastore.data_dictionary | |||
| route_name: metastore.data_dictionary.settings | |||
| weight: 2 | |||
There was a problem hiding this comment.
If updating the menu, you'll need to add a post update hook.
There was a problem hiding this comment.
I think anyone updating code is familiar with clearing cache afterwards.
QA Steps