Use the latest published dataset revision when returning results for the datastore query endpoint #4047
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the latest published dataset revision when returning results for the datastore query endpoint.
Also does some slight cleanup of the DatasetBTB test.
To recreate the error in a vanilla DKAN site:
Create a published dataset with a distribution.
Set the default moderation state to "draft".
Edit the dataset and replace the distribution file with data that is recognizably different than the published version. Save as a draft.
Run cron to do the imports
Visit the dataset page in the site and confirm that the published version of the dataset is still displayed.
Use the datastore query endpoint {domain}/api/1/datastore/query/{dataset}/{index} and observe that the data returned is from the unpublished draft, not the published version.
Test coverage exists
Documentation exists
QA Steps