Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finalize filefetcher custom processor DX #4074

Merged
merged 23 commits into from
Dec 14, 2023
Merged

Finalize filefetcher custom processor DX #4074

merged 23 commits into from
Dec 14, 2023

Conversation

paul-m
Copy link
Contributor

@paul-m paul-m commented Nov 30, 2023 •
edited

  • Uses ^5.0.2 of getdkan/file-fetcher.
  • Supports creating new file fetcher processors, using decorated file fetcher factory services.
  • Modifies existing tests towards this end.
  • Adds new tests and a custom_processor_test test module as an example implementation to test against.
  • Documents the process for developers within the user guide.

@jastraat
Copy link
Contributor

jastraat commented Dec 6, 2023

I have not been able to recreate the error we were seeing before this PR when testing with this PR and PDC!

@paul-m paul-m marked this pull request as ready for review December 11, 2023 21:43
@paul-m paul-m marked this pull request as draft December 11, 2023 23:34
dafeder
dafeder requested changes Dec 12, 2023
View reviewed changes
Copy link
Member

@dafeder dafeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some styling and structure suggestions

docs/source/user-guide/guide_file_fetchers.rst Outdated Show resolved Hide resolved
docs/source/user-guide/guide_file_fetchers.rst Outdated Show resolved Hide resolved
docs/source/user-guide/guide_file_fetchers.rst Outdated Show resolved Hide resolved
docs/source/user-guide/guide_file_fetchers.rst Outdated Show resolved Hide resolved
docs/source/user-guide/guide_file_fetchers.rst Outdated Show resolved Hide resolved
docs/source/user-guide/guide_file_fetchers.rst Show resolved Hide resolved
docs/source/user-guide/guide_file_fetchers.rst Outdated Show resolved Hide resolved
paul-m and others added 5 commits December 12, 2023 09:57
@paul-m @dafeder
Update docs/source/user-guide/guide_file_fetchers.rst
4de2e9b 
Co-authored-by: Dan Feder <dan.feder@civicactions.com>
@paul-m @dafeder
Update docs/source/user-guide/guide_file_fetchers.rst
00933f4 
Co-authored-by: Dan Feder <dan.feder@civicactions.com>
@paul-m @dafeder
Update docs/source/user-guide/guide_file_fetchers.rst
de52e7c 
Co-authored-by: Dan Feder <dan.feder@civicactions.com>
@paul-m @dafeder
Update docs/source/user-guide/guide_file_fetchers.rst
0164fd7 
Co-authored-by: Dan Feder <dan.feder@civicactions.com>
@paul-m
rework docs
c2f0237
@paul-m paul-m marked this pull request as ready for review December 12, 2023 18:12
jastraat
jastraat approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@jastraat jastraat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works great for PDC and actually fixes longstanding issues.

@dafeder dafeder merged commit 00bfcb5 into 2.x Dec 14, 2023
12 checks passed
@paul-m paul-m deleted the 18032-custom-processors branch December 14, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dafeder dafeder dafeder approved these changes

@jastraat jastraat jastraat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@paul-m @jastraat @dafeder