Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dataset template to display page layout when view_mode == full #4079

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Update dataset template to display page layout when view_mode == full #4079

merged 1 commit into from
Dec 13, 2023

Conversation

janette
Copy link
Member

@janette janette commented Dec 8, 2023

QA Steps

  • Create a dataset and save
  • Edit the dataset and save so there is a revision
  • Click edit again and then click the revisions tab
  • Select the revision and confirm it displays the full dataset page and not just the title and description.

@janette janette requested a review from dgading December 8, 2023 19:36
jastraat
jastraat approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@jastraat jastraat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jastraat jastraat merged commit 436abfa into 2.x Dec 13, 2023
12 checks passed
@jastraat jastraat deleted the revision-display branch December 13, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jastraat jastraat jastraat approved these changes

@dgading dgading Awaiting requested review from dgading

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@janette @jastraat