New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support PHP 8.2 #4085
Merged
Support PHP 8.2 #4085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dafeder
approved these changes
Jan 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Awesome work everyone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mainly does the following:
composer.json
.We then use a local dev environment and CI test results to adjust the following categories of changes to avoid deprecation messages:
JsonSerializable::jsonSerialize()
.We also take the opportunity to update
rector.php
. This brings our codebase up to snuff for PHP 7.4, and conservatively ends up making these changes:$this->staticMethod()
toself::staticMethod()
conversions.list()
to[$item, $item2]
conversion.It's important to note that if you look at the test results for the PHP 8.2 environment in this CI, you'll see deprecation messages like this:
This is a known issue for Drupal core, seen here: https://www.drupal.org/project/drupal/issues/3368250
This led to a 'workaround' PR to fix a test: #4104