Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ltrim with str_replace in json_form_widget #4087

Merged
merged 1 commit into from Jan 2, 2024

Conversation

janette
Copy link
Member

@janette janette commented Dec 28, 2023

An ltrim followed by a second parameter will trim any matching contiguous character(s) from the left side of the email address. e.g. matildafoo@test.com will become dafoo@test.com

Switching to str_replace will result in only removing an exact match on "mailto:"

QA Steps

  • Create a dataset, fill in the ContactPoint email field with "matildafoo@test.com", and save
  • view or edit the dataset to confirm the value was saved correctly

Copy link
Collaborator

@tiffneybare tiffneybare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good locally

@tiffneybare tiffneybare merged commit 2f9b794 into 2.x Jan 2, 2024
12 checks passed
@tiffneybare tiffneybare deleted the 17588-email-processing branch January 2, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants