Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use literal identifier for FileFetcherJobStoreFactory #4090

Merged
merged 2 commits into from Jan 11, 2024
Merged

Use literal identifier for FileFetcherJobStoreFactory #4090

merged 2 commits into from Jan 11, 2024

Conversation

paul-m
Copy link
Contributor

@paul-m paul-m commented Jan 9, 2024 •
edited

Following the work of #4083

Adds a FileFetcherJobStoreFactory class, which subclasses AbstractJobStoreFactory.

FileFetcherJobStoreFactory uses a literal table name of jobstore_524493904_filefetcher.

Adds this new class as a service: dkan.common.filefetcher_job_store_factory.

Changes service definitions which use dkan.common.job_store to use dkan.common.filefetcher_job_store_factory.

Changes all the services to accept FileFetcherJobStoreFactory instead of JobStoreFactory.

Modifies tests to use the new service.

@paul-m paul-m marked this pull request as ready for review January 9, 2024 22:05
@dafeder
Copy link
Member

dafeder commented Jan 10, 2024

Tested from upgrade perspective; imported, switched to branch, confirmed datastore and dashboard statuses still match.

jastraat
jastraat reviewed Jan 10, 2024
View reviewed changes
Copy link
Contributor

@jastraat jastraat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this out with PDC and did not see any issues.

dafeder
dafeder approved these changes Jan 11, 2024
View reviewed changes
Copy link
Member

@dafeder dafeder left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, want to check behavior of datastore and import status dashboard after upgrade

@dafeder dafeder merged commit a8c2f44 into 2.x Jan 11, 2024
12 checks passed
@dafeder dafeder deleted the 17150-filefetcherjobstore-literal branch January 11, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jastraat jastraat jastraat left review comments

@dafeder dafeder dafeder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@paul-m @dafeder @jastraat