Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data Dictionary Field Widget #4138

Merged
merged 42 commits into from
Apr 16, 2024
Merged

Data Dictionary Field Widget #4138

merged 42 commits into from
Apr 16, 2024

Commits on Apr 15, 2024

  1. New Data-Dictionary-Widget created for the purposes of displaying fie… 

    …lds for the field_json_metadata data node to collect information for the data-dictionary
    @kaise-lafrai
    kaise-lafrai committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    940996e View commit details
    Browse the repository at this point in the history

  2. Entity form display alter added to determine when to display Data-Dic… 

    …tionary-Field-Widget
    @kaise-lafrai
    kaise-lafrai committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    b9ff709 View commit details
    Browse the repository at this point in the history

  3. Added docblock

    @kaise-lafrai
    kaise-lafrai committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    43c0aed View commit details
    Browse the repository at this point in the history

  4. Updated docblock

    @kaise-lafrai
    kaise-lafrai committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    1f5be67 View commit details
    Browse the repository at this point in the history

  5. Cleaned up the .info.yml file

    @kaise-lafrai
    kaise-lafrai committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    9a0970e View commit details
    Browse the repository at this point in the history

  6. Refactored code to pass code-climate findings

    @kaise-lafrai
    kaise-lafrai committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    b7defe3 View commit details
    Browse the repository at this point in the history

  7. Refactored code, added functional browser test base for data-dictiona… 

    …ry-widget
    @kaise-lafrai
    kaise-lafrai committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    34b7dea View commit details
    Browse the repository at this point in the history

  8. Adjusted annotations

    @kaise-lafrai
    kaise-lafrai committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    2a965d2 View commit details
    Browse the repository at this point in the history

  9. Renamed test, adjusted test annotations

    @kaise-lafrai
    kaise-lafrai committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    1f85e97 View commit details
    Browse the repository at this point in the history

  10. Refactored datadictionarywidget to handle null json when creating for… 

    …m elements
    @kaise-lafrai
    kaise-lafrai committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    79958c6 View commit details
    Browse the repository at this point in the history

  11. created a new subform to collect field details and display in a table… 

    …, added twig template for the output of the table to handle formatting of the table fields
    @kaise-lafrai
    kaise-lafrai committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    f11ee23 View commit details
    Browse the repository at this point in the history

  12. Added validation, adjusted Add field, Add, Cancel buttons to be ajax/… 

    …submit callbacks, adjusted custom-table
    @kaise-lafrai
    kaise-lafrai committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    53ff445 View commit details
    Browse the repository at this point in the history

  13. removed file not needed

    @kaise-lafrai
    kaise-lafrai committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    f430fd4 View commit details
    Browse the repository at this point in the history

  14. adding edit and remove functionality

    @kaise-lafrai
    Tiffney Bare authored and kaise-lafrai committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    122714c View commit details
    Browse the repository at this point in the history

  15. adding logic to error out when submitted identifier is taken

    @kaise-lafrai
    Tiffney Bare authored and kaise-lafrai committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    3b34188 View commit details
    Browse the repository at this point in the history

  16. fixed edit logic so descriptions would show

    @kaise-lafrai
    Tiffney Bare authored and kaise-lafrai committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    79a5df1 View commit details
    Browse the repository at this point in the history

  17. adding updated twig file

    @kaise-lafrai
    Tiffney Bare authored and kaise-lafrai committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    61251bb View commit details
    Browse the repository at this point in the history

  18. finishing edit fuctionality

    @kaise-lafrai
    Tiffney Bare authored and kaise-lafrai committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    5034a4a View commit details
    Browse the repository at this point in the history

  19. making sure format options change when first editing based on current… 

    … selection
    @kaise-lafrai
    Tiffney Bare authored and kaise-lafrai committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    463cdba View commit details
    Browse the repository at this point in the history

  20. fixing array error found while eng review

    @kaise-lafrai
    Tiffney Bare authored and kaise-lafrai committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    b1c183f View commit details
    Browse the repository at this point in the history

  21. fixing code lint errors

    @kaise-lafrai
    Tiffney Bare authored and kaise-lafrai committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    8f6cb7d View commit details
    Browse the repository at this point in the history

  22. adding missing controller

    @kaise-lafrai
    Tiffney Bare authored and kaise-lafrai committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    40278a5 View commit details
    Browse the repository at this point in the history

  23. refactoring code for data_dictionary_widget

    @kaise-lafrai
    Tiffney Bare authored and kaise-lafrai committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    0775cdc View commit details
    Browse the repository at this point in the history

  24. Removig bulk changes work

    @kaise-lafrai
    Tiffney Bare authored and kaise-lafrai committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    fa164b7 View commit details
    Browse the repository at this point in the history

  25. Data dictionary widget php errors fixes (#4131)

    @kaise-lafrai
    kaise-lafrai committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    2177046 View commit details
    Browse the repository at this point in the history

  26. Place the data_dictionary_widget module as a dependency for the DKAN … 

    …module
    @kaise-lafrai
    kaise-lafrai committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    ba4fb75 View commit details
    Browse the repository at this point in the history

  27. Added a check to make sure that the identifer value exists in the for… 

    …m before validation
    @kaise-lafrai
    kaise-lafrai committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    63f4553 View commit details
    Browse the repository at this point in the history

  28. Adjusted phpunit.xml to ignore test directory, Added a new test that … 

    …loads a new data dictionary widget and verifies that the identifier, title and data dictionary section exists.
    @kaise-lafrai
    kaise-lafrai committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    942e17d View commit details
    Browse the repository at this point in the history

  29. Added new unit test to verify that the form fields exists when adding… 

    … a new data dictionary field
    @kaise-lafrai
    kaise-lafrai committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    a3d4d7e View commit details
    Browse the repository at this point in the history

  30. Added a unit test that validates the creating of a row in the data fo… 

    …r the data dictionary fields
    @kaise-lafrai
    kaise-lafrai committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    207da9b View commit details
    Browse the repository at this point in the history

  31. Added new test to validate adding a new dictionary field, reformated … 

    …some code to satisfy code climate
    @kaise-lafrai
    kaise-lafrai committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    a067a75 View commit details
    Browse the repository at this point in the history

  32. Added new tests that load the subform when editing an existing data d… 

    …ictionary field, added a new test to update a field and save the edited data dictionary field
    @kaise-lafrai
    kaise-lafrai committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    82d7252 View commit details
    Browse the repository at this point in the history

  33. Moved away from extending the ControllerBase class and created helper… 

    … classes placed in the Fields folder, Fixed the file name and yml structure of the libraries.yml file, moved css folder and file into the module root, added code in .module to attach the library and css because it was originally not loading on the data dictionary form.
    @kaise-lafrai
    kaise-lafrai committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    ead750e View commit details
    Browse the repository at this point in the history

  34. Adjusted spacing in class name to prevent codeclimate failure

    @kaise-lafrai
    kaise-lafrai committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    7e3ece9 View commit details
    Browse the repository at this point in the history

  35. Checking if array key dictionary_fields exists before running through… 

    … form alter
    @kaise-lafrai
    kaise-lafrai committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    307dbfe View commit details
    Browse the repository at this point in the history

  36. Added custom validation for the form, introduced code that restores f… 

    …ield values after a form state rebuild where validation errors get triggered
    @kaise-lafrai
    kaise-lafrai committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    e025eb5 View commit details
    Browse the repository at this point in the history

  37. Added steps to insure that existing data dictionary indexes are not l… 

    …ost and have somewhere to live in the field_json_metadata. Once index features are built this can be refactored.
    @kaise-lafrai
    kaise-lafrai committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    b075394 View commit details
    Browse the repository at this point in the history

  38. Adding data dictionary widget module as a dependency for dkan module.

    @kaise-lafrai
    kaise-lafrai committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    bf2d7e4 View commit details
    Browse the repository at this point in the history

  39. Refactored field creation to include a place for existing data dictio… 

    …nary indexes to persist, updated the widget to save the indexes if one exists, small bug fix with the cancel button
    @kaise-lafrai
    kaise-lafrai committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    9905c65 View commit details
    Browse the repository at this point in the history

  40. Code refactored to satisfy CodeClimate issues, Identifier field is no… 

    …w a randomly generated UUID, Code cleanup.
    @kaise-lafrai
    kaise-lafrai committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    8675ff5 View commit details
    Browse the repository at this point in the history

  41. Data dictionary title save and render schema adjustment

    @kaise-lafrai
    kaise-lafrai committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    1f586e4 View commit details
    Browse the repository at this point in the history

  42. Set default value for data dictionary title

    @kaise-lafrai
    kaise-lafrai committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    31c32e9 View commit details
    Browse the repository at this point in the history