Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to list of data dictionaries #4160

Merged
merged 4 commits into from Apr 17, 2024
Merged

Conversation

janette
Copy link
Member

@janette janette commented Apr 15, 2024

  • Updates the 'Data Dictionary' menu item to take user to a data dictionary view
  • Title links in the data dictionary view send you to the API endpoint
  • The default dataset content view alter code updated to check if the dkan_js_frontend module is enabled. If yes, titles link to the react dataset page. If no, titles link to the Drupal node route.

QA Steps

  • Checkout this branch
  • ddev drush en sample-content dkan_js_frontend -y
  • ddev dkan-frontend-install
  • ddev dkan-frontend-build
  • ddev drush dkan:sample-content:create
  • ddev drush cron
  • ddev drush uli
  • Use the DKAN menu, click on "Data Dictionary"
  • Confirm you end up on a data dictionary view
  • Confirm there is a button for adding a new data dictionary
  • Create a data dictionary and return to the list view
  • Click the title of the data dictionary
  • Confirm you see the API endpoint for the data dictionary
  • Visit /admin/dkan/datasets
  • Confirm title links take you to the react dataset page
  • ddev drush pmu dkan_js_frontend -y
  • ddev drush cr
  • Visit /admin/dkan/datasets
  • Confirm the title links take you to the /node/nid page

Copy link
Member

@dafeder dafeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - one note, I think submitting a data dictionary needs to redirect to the list, not back to the dataset list. But we can address that in a future PR.

@dafeder dafeder merged commit a97a4c0 into 2.x Apr 17, 2024
10 checks passed
@dafeder dafeder deleted the data-dictionary-admin-link branch April 17, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants