Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redirect to data-dictionary list after form submission #4166

Merged
merged 5 commits into from
Apr 25, 2024
Merged

Redirect to data-dictionary list after form submission #4166

merged 5 commits into from
Apr 25, 2024

Conversation

janette
Copy link
Member

@janette janette commented Apr 18, 2024

When user submits a new data dictionary, and it saves successfully, user should end up on /admin/dkan/data-dictionaries.

QA Steps

  • checkout this branch
  • ddev dkan-site-install
  • ddev drush uli
  • Under the DKAN menu, select Datasets > Create
  • Save new dataset
  • Confirm you end up on the datasets admin view
  • Under the DKAN menu, select Data Dictionary > Create
  • Save new data dictionary
  • Confirm you end up on the data dictionary admin view

@janette janette marked this pull request as draft April 18, 2024 18:19
@janette janette marked this pull request as ready for review April 18, 2024 19:10
@janette janette mentioned this pull request Apr 18, 2024
Merged
paul-m
paul-m requested changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@paul-m paul-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a regression test... I think this should be able to be a BTB test.

modules/metastore/metastore.install Outdated Show resolved Hide resolved
@janette janette force-pushed the redirect-on-data-dictionary-submit branch from 0389a14 to ca0ede8 Compare April 24, 2024 19:58
@paul-m paul-m changed the title Redirect on data dictionary submit Redirect to data-dictionary list after form submission Apr 25, 2024
@paul-m paul-m merged commit 77572ae into 2.x Apr 25, 2024
10 checks passed
@paul-m paul-m deleted the redirect-on-data-dictionary-submit branch April 25, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paul-m paul-m paul-m approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@janette @paul-m