Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow null on getHarvestRunResult #4182

Merged
merged 2 commits into from May 10, 2024
Merged

Allow null on getHarvestRunResult #4182

merged 2 commits into from May 10, 2024

Conversation

janette
Copy link
Member

@janette janette commented May 7, 2024 •
edited by rovcase

fixes 20484

Error: Call to a member function toResult() on null in Drupal\harvest\HarvestService->getHarvestRunResult() (line 258 of modules/contrib/dkan/modules/harvest/src/HarvestService.php).

QA Steps

  • Stand up a local site with existing harvests.
  • ddev updb -y
  • ddev cr
  • Visit /admin/dkan/datastore/status
  • Confirm you see the dashboard and not the error

@rovcase rovcase assigned rovcase and unassigned rovcase May 10, 2024
@rovcase rovcase self-requested a review May 10, 2024 14:56
rovcase
rovcase approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@rovcase rovcase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@rovcase rovcase merged commit 75eb012 into 2.x May 10, 2024
10 checks passed
@rovcase rovcase deleted the allow-null-on-getHarvestRunResult branch May 10, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rovcase rovcase rovcase approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@janette @rovcase @paul-m