Fix broken reference in OpenAPI spec, improve validation tests #4201
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some inconsistencies in the responses for the metastore section of the OpenAPI spec. Changing them broke the crude response validator I had implemented using OPIS schema validation. This fixes up the spec and switches to using osteel/openapi-httpfoundation-testing for response validation, which is I think a better approach.
QA Steps
Merging instructions
Notes
Re: codeclimate, that function is completely declarative and wouldn't benefit from breaking up, so I think ok to override.
This PR removes Drupal 10.0 from the CI matrix, which was creating dependency issues for the openapi library. 10.0 is no longer supported so we feel comfortable dropping testing for it. This does not mean that production builds with DKAN will fail for 10.0, but core PHPUnit tests will.