Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code climate complexity issues #377

Open
5 tasks
janette opened this issue Apr 7, 2020 · 0 comments
Open
5 tasks

Fix code climate complexity issues #377

janette opened this issue Apr 7, 2020 · 0 comments

Comments

@janette
Copy link
Member

janette commented Apr 7, 2020

  • Method formElement has 5 arguments (exceeds 4 allowed).
public function formElement(FieldItemListInterface $items, $delta, array $element, array &$f

Found in modules/custom/json_schema_field/src/Plugin/Field/FieldWidget/JsonSchemaFormWidget.php


  • Method __construct has 5 arguments (exceeds 4 allowed).
public function __construct(array $configuration, $plugin_id, $plugin_definition, Connection

Found in modules/dkan_non_public/src/Plugin/DataModifier/NonPublicResourceProtector.php


  • ComplexDataFacade has 24 functions (exceeds 20 allowed).
class ComplexDataFacade implements \Iterator, ComplexDataInterface {

Found in modules/dkan_search/src/Facade/ComplexDataFacade.php


  • Method __construct has 6 arguments (exceeds 4 allowed).
Service $service,
    Connection $database,
    Resource $resourceServiceFactory,
    RequestStack $requestStack,
    DatabaseTableFactory $databaseTableFactory,

Found in modules/dkan_sql_endpoint/src/Controller/Api.php


  • Function expandDirectories has a Cognitive Complexity of 8 (exceeds 5 allowed).
private function expandDirectories($base_dir) {
    $directories = [];
 
    if (!file_exists($base_dir)) {
      return $directories;

Found in modules/dkan_frontend/src/Routing/RouteProvider.php

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant