Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Ability to activate a lightbox for featured images #1304

Closed
Kalistia opened this issue Dec 9, 2023 · 7 comments
Closed

Comments

@Kalistia
Copy link

Kalistia commented Dec 9, 2023

Feature Description

It would be really nice to have the option to activate or not a lightbox view for the featured images on the articles

@atomGit
Copy link

atomGit commented Dec 12, 2023

...or any single image for that matter

@bobmitro
Copy link
Collaborator

I'm closing this topic because it's more relevant to a Publii plugin rather than the core functionality of Publii itself.

@atomGit
Copy link

atomGit commented Dec 12, 2023

you have an album feature and the code to support it - why would providing lightbox functionality for single images not be handled by the very same code?

@Kalistia
Copy link
Author

Kalistia commented Dec 12, 2023 via email

@bobmitro
Copy link
Collaborator

The lightbox requires CSS and JavaScript, which must be attached to your site. In the Gallery, despite the UI delivered with Publii, the scripts are provided by the theme, not the app.

The lightbox in my option should work automatically; when the user clicks the image, the script should detect this image and display the original (big) image in the popup. The best for that will be a plugin that will catch the pictures and display them in the Lightbox.

Not everyone requires this feature, so it's unnecessary to clutter the interface overly. Incorporating every user-requested option could result in an excessively crowded interface.

Also, a plugin will be easier to maintain and update.

@dziudek
Copy link
Collaborator

dziudek commented Dec 12, 2023

Definitely - decoupling lightbox mechanism from Publii is a good solution. When we will add this, then there will be people who wants other script/effect etc. It should be solved on the theme/plugin level

@Kalistia
Copy link
Author

Thanks guys, that makes more sense to me now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants