Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1224 - added option to disable certificate's validation during Gitlab connection #1225

Merged
merged 4 commits into from Sep 26, 2023

Conversation

sc0ttes
Copy link
Contributor

@sc0ttes sc0ttes commented Jun 27, 2023

No description provided.

@sc0ttes
Copy link
Contributor Author

sc0ttes commented Jun 27, 2023

While "Test connection" seems to have worked, it turned out that actually syncing the site had not been because of a typo in the client instantiation where the url parameter should have been host. Surprisingly that was set correctly for the test.

This was causing 401 Unauthorized errors anytime you tried to sync even though the connection test was succeeding.

This has now been tested on a self-hosted Gitlab instance and confirmed working.

@dziudek dziudek merged commit 74d9967 into GetPublii:master Sep 26, 2023
@dziudek
Copy link
Collaborator

dziudek commented Sep 26, 2023

@sc0ttes - thank you for this change - I will also add translation possibility in the UI :)

dziudek added a commit that referenced this pull request Sep 26, 2023
#1224 - added option to disable certificate's validation during Gitlab connection
dziudek added a commit that referenced this pull request Sep 26, 2023
@sc0ttes sc0ttes deleted the patch-1 branch September 27, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants