Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Identity instances #116

Merged
merged 3 commits into from
Sep 10, 2017
Merged

Conversation

mithrandi
Copy link
Contributor

@mithrandi mithrandi commented Sep 4, 2017

Closes #115.

I bumped the Stack resolver since things wouldn't build with lts-8.0.

Also, I wasn't sure whether the ToSchema instance should be using unname or not; I don't really understand why some existing instances use it and some don't.

@fizruk fizruk merged commit 9f92754 into GetShopTV:master Sep 10, 2017
@fizruk
Copy link
Member

fizruk commented Sep 10, 2017

Thanks!

Now that you ask, I'm not sure why I have used unname :)

Perhaps I wanted to alter schemas for some newtypes and having the same name for different schemas would produce a malformed Swagger spec. For Identity I don't think that's a problem, so let it remain named.

@mithrandi mithrandi deleted the identity-instances branch September 10, 2017 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ToSchema/ToParamSchema instances for Identity
2 participants