Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow allOf to accept referenced schemas fix #119 #120

Merged
merged 1 commit into from
Sep 10, 2017

Conversation

rodrigosetti
Copy link
Contributor

No description provided.

@fizruk fizruk merged commit 7e55105 into GetShopTV:master Sep 10, 2017
@fizruk
Copy link
Member

fizruk commented Sep 10, 2017

Thanks!

A minor note: don't bump version in a feature PR, releases are normally done separately, because:

  • there might be other unreleased changes (there are in this case);
  • you should not think about version numbers when implementing a feature.

@rodrigosetti rodrigosetti deleted the referenced-allof branch September 11, 2017 00:34
@rodrigosetti
Copy link
Contributor Author

rodrigosetti commented Sep 11, 2017

Thanks. I would be happy to address your notes, but I see you already merged :)

Consider adding a CONTRIBUTING file, it's nicely supported by Github, there are projects where maintainers have the inverse rule (all PRs should increase version).

@fizruk
Copy link
Member

fizruk commented Sep 11, 2017

@rodrigosetti yes, I guess I should add a CONTRIBUTING file, thanks for suggestion! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants