Make nullary schemas valid #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fizruk
reviewed
Sep 27, 2018
src/Data/Swagger/Internal.hs
Outdated
| @@ -1050,6 +1050,10 @@ instance ToJSON (ParamSchema t) => ToJSON (SwaggerItems t) where | |||
| [ "collectionFormat" .= fmt | |||
| , "items" .= schema ] | |||
| toJSON (SwaggerItemsObject x) = object [ "items" .= x ] | |||
| toJSON (SwaggerItemsArray []) = object -- Nullary schema, cf. <https://github.com/GetShopTV/swagger2/issues/167>. | |||
There was a problem hiding this comment.
Can you make that comment into a haddock documentation for this instance and add a doctest?
|
ping @michalrus |
michalrus
force-pushed
the
nullary-schema-valid
branch
from
b4ce7b4
to
dd47ca9
Compare
|
Hey, updated with @fizruk’s suggestions. I hope this passes… Sorry for the delay. =) |
michalrus
force-pushed
the
nullary-schema-valid
branch
from
dd47ca9
to
9d48823
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #167
Because of
toJSON · fromJSON ≠ ±idforSwaggerItems, I had to modifyinstance ToJSON Schemato make tests pass… (+ we don’t have lens here yet).Ugly…
/cc @phadej @fizruk