Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHC 8.10 support #210

Merged
merged 3 commits into from
Apr 22, 2020
Merged

GHC 8.10 support #210

merged 3 commits into from
Apr 22, 2020

Conversation

swamp-agr
Copy link
Collaborator

Hi @fisx, @phadej,

This PR intended to close #208.

Details

  • Relax boundaries to allow build with GHC 8.10.1.
  • Bump LTS to enable build via stack with GHC 8.8.1 by default.
  • Resolve test fail:
    Test suite doctests: RUNNING...
    
    ./swagger2/src/Data/Swagger/Declare.hs:165:46: warning: [-Wdeprecations]
        In the use of type constructor or class ‘ListT’
        (imported from Control.Monad.List, but defined in Control.Monad.Trans.List):
        Deprecated: "This transformer is invalid on most monads"
        |
    165 | instance MonadDeclare d m => MonadDeclare d (ListT m) where
        |                                              ^^^^^
    Test suite doctests: FAIL
    

I have enabled stylish-haskell by default. If you disagree with auto-formatting, I will undo formatting changes.

Thanks,
@swamp-agr

@swamp-agr swamp-agr requested review from phadej and fisx April 20, 2020 18:30
@swamp-agr swamp-agr changed the title Ghc810 support GHC 8.10 support Apr 20, 2020
@fizruk
Copy link
Member

fizruk commented Apr 21, 2020

@swamp-agr stylish-haskell is ok, but please submit formatting changes as a separate PR :)

@swamp-agr
Copy link
Collaborator Author

@fizruk formatting reverted back (diff size reduced).
Tests passed. Please go ahead.

@swamp-agr swamp-agr merged commit 06b2f7f into master Apr 22, 2020
@swamp-agr swamp-agr deleted the ghc810-support branch April 22, 2020 08:17
@fisx
Copy link
Collaborator

fisx commented Apr 30, 2020

@swamp-agr stylish-haskell is ok, but please submit formatting changes as a separate PR :)

I would vote for ormolu instead of stylish haskell, though.

Sorry for the slow response, changes look good! I'm glad this made it to master in the end :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update bounds for GHC 8.10
3 participants