Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Aeson >=2.0.0.0 && <2.1 and GitHub Actions #228

Merged
merged 6 commits into from
Nov 11, 2021
Merged

Use Aeson >=2.0.0.0 && <2.1 and GitHub Actions #228

merged 6 commits into from
Nov 11, 2021

Conversation

alissa-tung
Copy link
Contributor

@alissa-tung alissa-tung commented Nov 9, 2021

close #226 , re #227
cc @swamp-agr @akhesaCaro
also close #223 , #225 , #214

@alissa-tung
Copy link
Contributor Author

Hello @fizruk , could you please help me enable the continuous-integration check

@alissa-tung
Copy link
Contributor Author

alissa-tung commented Nov 9, 2021

Seems okay except a macOS (stack) issue, I gonna inspect this.
https://github.com/alissa-tung/swagger2/actions/runs/1438001851


I had re-ran all jobs. The first time it works well for all other jobs except doctest of macOS (stack).


Same result. 7 successful and 1 failing checks

Copy link
Collaborator

@swamp-agr swamp-agr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alissa-tung thank you for your contribution!

✅ PR looks good to me.
CI might be enabled and processed separately.
I will check and prepare release today later.

@swamp-agr
Copy link
Collaborator

Seems okay except a macOS (stack) issue, I gonna inspect this.

According to the log doctests failed.

@swamp-agr
Copy link
Collaborator

As far as I understand:

  • Segfault appeared for stack (LTS-18.16) + GHC 8.10.7 + doctests as well as for cabal + GHC 9.0.1: https://gitlab.haskell.org/ghc/ghc/-/issues/19460.
  • To be more specific, following line will cause an error during doctests execution:
    instance ToSchema Person
    
  • It seems that doctests should be fixed in GHC 9.2.1.

@alissa-tung if you confirm that

  • ignoring such an error would work for you
  • GHC 8.8.4 would work fine

then we'll go release the package keeping in mind to add 9.2.1 support as soon as possible and either skipping 9.0.x and 8.10.x or explicitly mentioning mysterious behaviour of compiler and tooling.

@alissa-tung
Copy link
Contributor Author

alissa-tung commented Nov 9, 2021

CI might be enabled and processed separately. I will check and prepare release today later.

I am not sure the stagey for GitHub to take when removing the Travis CI file and add Actions .github/workflows/ci.yml. Which one would be better to make further development (Travis CI, GitHub Actions or both)? If we are going to enable actions the README.md should be updated later.

stack (LTS-18.16) + GHC 8.10.7 + doctests works fine on my machine.
But tested Cabal with 9.0.1 failed.
In fact I am curious about why Ubuntu + stack.yaml works fine but macOS failed with the same result. 🤔
Thank you for shed light on the specific line! I had never thought about this way before 👍 I thinking the way of discovering must be mysterious.
We can keep in touch with the test result with Cabal by adding more GHC version constraints in the GitHub Actions matrix. For stack maybe we should add more stack files.


GHC 8.8.4 would work fine?

If it is not caused by the changes I had made 🤔 btw another project I am working on uses 8.10.4 with swagger2 everyday and no issue like this had been noticed before. or it merely affects the GHCi? im not sure. Let's add it into CI and see.

@alissa-tung
Copy link
Contributor Author

alissa-tung commented Nov 9, 2021

The status of CI for 8.8.4 can be found here.

@swamp-agr
Copy link
Collaborator

swamp-agr commented Nov 9, 2021

Personally I want to get rid of Travis CI since after it changed its host (from travis-ci.org to travis-ci.com) we have a plenty of jobs stalled here. And I have no control on it. I cannot bypass restrictions set on this repository. Github Actions seems like a good choice, thank you for advising and setting it up.

@fizruk could you please go ahead and shut down Travis CI integration permanently? Unfortunately, I cannot do it by myself.

Screenshot 2021-11-09 at 15 23 18

@alissa-tung
Copy link
Contributor Author

alissa-tung commented Nov 11, 2021

cc @swamp-agr seems that the blocking status is canceled. looking forward to your review opinions

@swamp-agr swamp-agr merged commit 9846955 into GetShopTV:master Nov 11, 2021
@swamp-agr
Copy link
Collaborator

swamp-agr commented Nov 11, 2021

@alissa-tung please find package released on Hackage: https://hackage.haskell.org/package/swagger2-2.7.
thanks for your contribution!

This was referenced Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aeson security Issue (Servant dependency)
2 participants