Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GHC 9.2 #231

Merged
merged 1 commit into from
Feb 3, 2022
Merged

Support GHC 9.2 #231

merged 1 commit into from
Feb 3, 2022

Conversation

brandon-leapyear
Copy link
Contributor

@brandon-leapyear brandon-leapyear commented Feb 2, 2022

This is an old work account. Please reference @brandonchinn178 for all future communication


Resolves #227, uses the fix in the comments

@ysangkok
Copy link
Contributor

ysangkok commented Feb 2, 2022

Does the test suite pass for you with this patch applied? Because it didn't for me (as you can see in the bottom of that comment you refer to).

@brandon-leapyear
Copy link
Contributor Author

brandon-leapyear commented Feb 2, 2022

This is an old work account. Please reference @brandonchinn178 for all future communication


I haven't tried; I just needed the bounds updated to get Servant building on GHC 9.2

@swamp-agr
Copy link
Collaborator

@ysangkok there is long-standing GHC bug that should be fixed in 9.2, i.e. failing doctests such as:

instance ToSchema Person

Surely, we can add that support. I was hoping that bug will gone. Let me further look into that.

@swamp-agr
Copy link
Collaborator

Other (unrelated to this PR) thing I want to pay attention is too relaxed aeson boundary which produces failing CI pipeline. Since there is nothing to do with GHC 9.2, let me fix it in separate PR.

@ysangkok
Copy link
Contributor

ysangkok commented Feb 3, 2022

@swamp-agr The PR I made yesterday doesn't fix the aeson issue?

@swamp-agr
Copy link
Collaborator

@ysangkok for some reason I missed it.

@swamp-agr
Copy link
Collaborator

@brandon-leapyear could you please rebase/merge over the Merged #230?

@brandon-leapyear
Copy link
Contributor Author

brandon-leapyear commented Feb 3, 2022

This is an old work account. Please reference @brandonchinn178 for all future communication


Done

@swamp-agr swamp-agr merged commit 2fdb34d into GetShopTV:master Feb 3, 2022
@swamp-agr
Copy link
Collaborator

swamp-agr commented Feb 3, 2022

Thanks @brandon-leapyear! I just realised that we have to ensure on CI that 9.2 is good. I will check it separately via #232.

@swamp-agr
Copy link
Collaborator

Before release we have to investigate and potentially fix what is going on here (from CI):

Screenshot 2022-02-03 at 18 55 54

@brandon-leapyear brandon-leapyear deleted the ghc-9.2 branch February 3, 2022 17:58
@ysangkok
Copy link
Contributor

ysangkok commented Feb 3, 2022

@swamp-agr I have submitted a PR to fix that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GHC 9.2 support
3 participants