Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow newer dependencies #242

Merged
merged 1 commit into from
Sep 4, 2022
Merged

Allow newer dependencies #242

merged 1 commit into from
Sep 4, 2022

Conversation

ysangkok
Copy link
Contributor

@ysangkok ysangkok commented Aug 17, 2022

Includes #238. Fixes

Tested using

cabal test -w ghc-9.2.4 --enable-tests --constraint='aeson>=2.1' --constraint='lens>=5.2' --constraint='vector>=0.13' --constraint='hspec>=2.10'

l-epple added a commit to possehl-analytics/servant that referenced this pull request Sep 2, 2022
No code changes were required, just needed to bump the upper bounds.
servant-swagger already allows 5.2. In a normal situation you won't get
lens 5.2 yet, because swagger2 currently disallows lens 5.2:
GetShopTV/swagger2#242
Additionally, servant-multipart needs its constraint lifted as well
which I'll PR to the respective repository.

Tested using

    cabal v2-build all --allow-newer=lens --constraint='lens >= 5.2'
@dmjio
Copy link
Collaborator

dmjio commented Sep 4, 2022

@ysangkok thnx !

@dmjio dmjio merged commit 360c330 into GetShopTV:master Sep 4, 2022
@l-epple
Copy link

l-epple commented Sep 9, 2022

A release / hackage revision for this would be great, since I don't think any dependency updates require code changes compared to the last release on hackage.

@TeofilC TeofilC mentioned this pull request Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants