Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ghc-9.6 #246

Merged
merged 2 commits into from
Apr 13, 2023
Merged

Support ghc-9.6 #246

merged 2 commits into from
Apr 13, 2023

Conversation

ysangkok
Copy link
Contributor

@ysangkok ysangkok commented Apr 8, 2023

doctest v0.21.1 is the only version that supports GHC 9.6, but doctest v0.21.1 isn't
working well with OverloadedLists: sol/doctest#389

So I just removed the use of OverloadedLists.

Also, GHC 9.6 has numbered errors that are printed after "error:". So to make
the error still match, I just opted for removing this line from a doctest
instead of introducing an ifdef.

This contains allow-newers that could be removed when these changes are on Hackage:

@swamp-agr
Copy link
Collaborator

Thank you for your contribution! Good to see that allow-newer instructions covered with condition on the most recent GHC version range. We will keep a track on the mentioned packages and remove those when they will be released.

@swamp-agr swamp-agr self-requested a review April 13, 2023 18:01
@swamp-agr swamp-agr merged commit 0c8cc18 into GetShopTV:master Apr 13, 2023
@ysangkok ysangkok deleted the janus/ghc-9.6 branch April 13, 2023 22:06
@ysangkok
Copy link
Contributor Author

Thank you for the merge! Would it be possible to make a release/revision? Then we would be able to get Servant compatible with GHC-9.6 without an allow-newer for swagger2.

@swamp-agr
Copy link
Collaborator

Please expect release on Hackage by today's evening. Sure.

@swamp-agr
Copy link
Collaborator

Please find release on Hackage: https://hackage.haskell.org/package/swagger2-2.8.7

@ysangkok
Copy link
Contributor Author

Thank you very much, Andrey! Much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants