Replace aeson TH with Generics-based instances #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fizruk
added a commit
that referenced
this pull request
Dec 19, 2015
Replace aeson TH with Generics-based instances
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
aeson-0.10.0.0might be on Stackage soon, this change makesswagger2compatible with that particular version. The problem was a bug in aeson TH (see haskell/aeson#293) and this change replaces all TH with Generic-based instances which are more verbose, but also safer. Besides many JSON instances have been customized so not many are left using TH anyway.This change also drops
template-haskelldependency.