RFC: using generics-sop to derive some ToJSON instances #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phadej
force-pushed
the
aeson-generics-sop
branch
6 times, most recently
from
91eea7f
to
fa69bf1
Compare
phadej
force-pushed
the
aeson-generics-sop
branch
from
fa69bf1
to
e003a05
Compare
| @@ -1015,10 +1027,8 @@ instance ToJSON (CollectionFormat t) where | |||
| toJSON CollectionMulti = "multi" | |||
|
|
|||
| instance ToJSON (ParamSchema t) where | |||
| toJSON = omitEmptiesExcept f . genericToJSONWithSub "items" (jsonPrefix "paramSchema") | |||
| where | |||
| f "items" (Array _) = True | |||
There was a problem hiding this comment.
Hmm, how do you account for this with generics-sop?
There was a problem hiding this comment.
it falls out naturally as fields from sub-object aren't omitted. OTOH i'm looking for some kind of symmetric variant to do FromJSON, e.g. only omit fields which are specified in defaults if the values match.
Merged
|
Merged into #56 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #56 as using this we could write
sopSwaggerGenericToEncodingas by making own generics derivation, we don't need to postprocess existing values (we cannot postprocess `Encoding!)Here I also used
generics-sop, as it's just much more straightforward (for me).