Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UUID instances #81

Merged
merged 1 commit into from
Sep 26, 2016
Merged

Add UUID instances #81

merged 1 commit into from
Sep 26, 2016

Conversation

phadej
Copy link
Collaborator

@phadej phadej commented Sep 23, 2016

No description provided.

Copy link
Member

@fizruk fizruk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from minor comments looks good to me.

@@ -433,6 +434,8 @@ instance (ToSchema a, ToSchema b) => ToSchema (Either a b)
instance ToSchema () where
declareNamedSchema _ = pure (NamedSchema Nothing nullarySchema)

instance ToSchema UUID where declareNamedSchema = plain . paramSchemaToSchema
Copy link
Member

@fizruk fizruk Sep 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An example makes docs way nicer:

    & example ?~ toJSON UUID.nil

also not sure it should be unnamed.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

2.1.3
-----

* Add UUID instances
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, mention PR.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@phadej
Copy link
Collaborator Author

phadej commented Sep 26, 2016

travis is green

@fizruk fizruk merged commit 2c26881 into GetShopTV:master Sep 26, 2016
@phadej phadej deleted the uuid branch September 26, 2016 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants