-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UUID instances #81
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from minor comments looks good to me.
@@ -433,6 +434,8 @@ instance (ToSchema a, ToSchema b) => ToSchema (Either a b) | |||
instance ToSchema () where | |||
declareNamedSchema _ = pure (NamedSchema Nothing nullarySchema) | |||
|
|||
instance ToSchema UUID where declareNamedSchema = plain . paramSchemaToSchema |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An example makes docs way nicer:
& example ?~ toJSON UUID.nil
also not sure it should be unnamed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
2.1.3 | ||
----- | ||
|
||
* Add UUID instances |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, mention PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
travis is green |
No description provided.