You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I am trying to figure out what we should do with menu items with broken paths to them.
Parent [menu]
Child 1 [menu]
Child 2
Child 2 a [menu] <- where does this go
We either remove it, or push it to root like so
Parent [menu]
Child 1 [menu]
Child 2 a [menu]
We could also find closest parent in menu and add it there but that seems confusing and is a pain in the ass to do also since we wont be caching the parent
This will also cause issues if caching menus, as it makes getting child menus harder or impossible get_subnav('Child2') wont work if child2 isnt in the cache map
would seem to be the choice of least surprise, imo. It avoids adding to the Parent list (probably the main nav, which may break by wrapping), but remaining visible/accessible.
modify get_navigation for multilevel menus.
I also find it bad that we do not output an ol/ul container, or provide the option to.
The text was updated successfully, but these errors were encountered: