Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi level menus #1025

Open
tablatronix opened this issue Apr 5, 2015 · 3 comments
Open

multi level menus #1025

tablatronix opened this issue Apr 5, 2015 · 3 comments

Comments

@tablatronix
Copy link
Member

modify get_navigation for multilevel menus.

I also find it bad that we do not output an ol/ul container, or provide the option to.

@tablatronix tablatronix added this to the v3.4.0 milestone Apr 5, 2015
@tablatronix
Copy link
Member Author

I am trying to figure out what we should do with menu items with broken paths to them.

  • Parent [menu]
    • Child 1 [menu]
    • Child 2
      • Child 2 a [menu] <- where does this go

We either remove it, or push it to root like so

  • Parent [menu]
    • Child 1 [menu]
  • Child 2 a [menu]

We could also find closest parent in menu and add it there but that seems confusing and is a pain in the ass to do also since we wont be caching the parent

This will also cause issues if caching menus, as it makes getting child menus harder or impossible
get_subnav('Child2') wont work if child2 isnt in the cache map

@tablatronix
Copy link
Member Author

Since I cant decide how to handle this, i coded it to be able to do both.

SO it can do this instead

  • Parent [menu]
    • Child 1 [menu]
    • Child 2 a [menu]

I think i18n just hides them

  • Parent [menu]
    • Child 1 [menu]

@hameau
Copy link
Contributor

hameau commented Apr 9, 2015

This:

  • Parent [menu]
    • Child 1 [menu]
    • Child 2 a [menu]

would seem to be the choice of least surprise, imo. It avoids adding to the Parent list (probably the main nav, which may break by wrapping), but remaining visible/accessible.

@tablatronix tablatronix modified the milestones: 3.4.0, 3.5.0 Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants