Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove back end assets from public front end auth pages #592

Closed
6 of 7 tasks
tablatronix opened this issue Jun 25, 2013 · 5 comments
Closed
6 of 7 tasks

Remove back end assets from public front end auth pages #592

tablatronix opened this issue Jun 25, 2013 · 5 comments

Comments

@tablatronix
Copy link
Member

Remove

  • generator
  • author
  • apple icon
  • favicon
  • Remove all javascript and other assets not required by login form and reset password pages, exposes versioning and backend dependencies for no reason
  • Remove backend hooks. Header / Footer
  • Remove invisible elements ( footer/logo )
tablatronix added a commit that referenced this issue Jun 25, 2013
@tablatronix
Copy link
Member Author

Leaving in assets for now

@tablatronix
Copy link
Member Author

This change removes back end hooks from public auth pages to prevent data leakage and unintended consequences via bad plugin programming.

Now I would like to allow plugins to continue to modify these pages for custom login stuff, but I do not want to switch them to front end hooks as our template system does not support auth pages yet.

Perhaps we should add specific headers for public auth pages.

This includes Index and resetpassword pages.

@tablatronix
Copy link
Member Author

NOTE: These pages were never consistent to begin with, hooks were executed on resetpassword but not login, so now they match to neither execute backend hooks for reasoning that they are not back end pages, even if they are not front end either. They also had css hidden footers and other crap in them.

@tablatronix
Copy link
Member Author

From hameau
The javascript assets have version strings on them.

Will have to obfuscate these or remove them, I do not believe anything indexes assets, but a security scanner could be made to sniff these out and log them.

@tablatronix
Copy link
Member Author

#665

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant