This repository has been archived by the owner on Oct 12, 2021. It is now read-only.
Change ambiguous "Go" label to a more descriptive verb-based label for the submit button in the Add RSS & Add Podcast popups. #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…up's submit button. Very minor UI/UX improvement.
… popup's submit button. Very minor UI/UX improvement.
…up (differentiating between the Import OPML and Add RSS feed actions)
|
Nice, great change |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
A minor UI/UX improvement to the submit button on the Add RSS & Add Podcast popups. "Go" is generally a fallback option for a button as it's nondescript & requires understanding of the context. It's usually better to simply state the action that's going to be performed as the button's label to make it as clear as possible for the user. As such, the podcast popup has "Add Podcast" as the submit button's label, and the RSS popup switches between "Add RSS" and "Import OPML" depending if the "Import OPML" section has been expanded or not.
Alternate Designs
The simple "Add" option was initially chosen for simplicity while still being an improvement. "Add / Import" was also considered since the user might be adding an RSS feed or Importing OPML using this one button. I then opted to have the button change to "Add RSS", "Import OMPL", and "Add Podcast" accordingly.
Why Should This Be in Core?
This changes a UI element within the core app.
Benefits
The user will better understand the action that will be performed when clicking the button that was updated.
Possible Drawbacks
None that I can think of.
Applicable Issues
Just a general UI/UX improvement here. No open issues to reference.