AddToCalendar migration #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 'master' of github.com:GetStream/mml-react: fix rollup named exports
* 'master' of github.com:GetStream/mml-react: (46 commits) first story remove styleguidist rename converterConfig remove old docs folder convert parser to typescript converterConfig to typescript convert test files to tsx remove ts ignores refactor tags simplify parser Scheduler support selected attr snapshot examples fix converterConfig recursive call enable ci test fix babel test config jest config remove style import from carousel comment out LoadingIndicator in Loader component convert mml test to parser test parser to ts ...
… dep, fix outlookcom url construction, get rid of yahoo followinf source code comment, I had to add the resolutions key to prevent tsdx linting from erroring
|
Size Change: +983 B (1%) Total Size: 57.3 kB
ℹ️ View Unchanged
|
mahboubii
reviewed
Nov 18, 2020
| LOCATION: | ||
| END:VEVENT | ||
| END:VCALENDAR" | ||
| href="https://outlook.live.com/owa/?rru=addevent&startdt=2019-12-24T14%3A42%3A54Z&enddt=2019-12-24T15%3A42%3A54Z&subject=Massage%20with%20Jessica&allday=false&uid=00000000-0000-0000-0000-000000000000&path=/calendar/view/Month" |
There was a problem hiding this comment.
@kuus is this a valid link here?
| LOCATION: | ||
| END:VEVENT | ||
| END:VCALENDAR" | ||
| href="https://calendar.google.com/calendar/render?action=TEMPLATE&dates=20191224T144254Z/20191224T154254Z&text=Massage%20with%20Jessica" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrated AddToCalendar component to typescript, for this I had to add the
resolutionskey in the package.json as suggested in this issue in order to preventtsdx lintto break on commit prehook.small notes:
react-add-to-calendardep and add just two small deps:is-mobile(as I don't think we want to mantain a list of browser vendors :D)uuid(with mock forjest)momentjswithinreact-add-to-calendarwithdate-fnsand fixed outlookcom url building.