Minimize css output #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems broken indentation can cause issues in windows due to different line breaks. Css output is minimized to workaround it. Along the way, postcss-nested is upgraded and integrated stylelint-prettier and its config.
ferhatelmas
commented
Nov 15, 2019
| @@ -34,7 +34,7 @@ const variables = { | |||
| module.exports = { | |||
| plugins: { | |||
| 'postcss-easy-import': {}, | |||
| 'postcss-cssnext': {}, | |||
| 'postcss-cssnext': { warnForDuplicates: false }, | |||
There was a problem hiding this comment.
autoprefixer is loaded twice since nested and cssnest uses it.
Btw, we need to move to postcss-preset-env
jaapbakker88
approved these changes
Nov 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems broken indentation can cause issues in windows
due to different line breaks. Css output is minimized
to workaround it.
Along the way, postcss-nested is upgraded and integrated
stylelint-prettier and its config.