Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore events with shadowed messages #5234

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

JcMinarro
Copy link
Member

馃幆 Goal

Ignore events with shadowed messages
Close: https://github.com/GetStream/android-internal-board/issues/282

馃帀 GIF

@JcMinarro JcMinarro requested a review from a team as a code owner April 10, 2024 09:01
@JcMinarro JcMinarro force-pushed the fix/shadowed-messages-should-be-ignored branch from e300400 to dc69cd5 Compare April 12, 2024 12:03
Copy link
Collaborator

@kanat kanat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kanat
Copy link
Collaborator

kanat commented Apr 22, 2024

@JcMinarro could you fix the linter checks? :)

@JcMinarro JcMinarro enabled auto-merge (rebase) April 23, 2024 08:00
@JcMinarro JcMinarro force-pushed the fix/shadowed-messages-should-be-ignored branch from dc69cd5 to 9d7335a Compare April 23, 2024 08:00
@JcMinarro JcMinarro merged commit 1ac076a into develop Apr 23, 2024
8 checks passed
@JcMinarro JcMinarro deleted the fix/shadowed-messages-should-be-ignored branch April 23, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants