Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: some letter are cut-off #284

Merged
merged 1 commit into from
Apr 4, 2024
Merged

fix: some letter are cut-off #284

merged 1 commit into from
Apr 4, 2024

Conversation

szuperaz
Copy link
Collaborator

@szuperaz szuperaz commented Apr 4, 2024

🎯 Goal

Some letter are cut-off

Screenshot 2024-04-03 at 17 03 25

🛠 Implementation details

  • I've updated all line-height values to be unitless
  • I made sure we use at least 1.2 everywhere

Context: https://getstream.slack.com/archives/C06CF5TKRGA/p1712156840771619

🎨 UI Changes

Screenshot 2024-04-04 at 11 04 21 (1)

Make sure to test with both Angular and React (with both MessageList and VirtualizedMessageList components) SDKs

@szuperaz szuperaz merged commit 948dd70 into main Apr 4, 2024
@szuperaz szuperaz deleted the fix-overflow-in-message branch April 4, 2024 11:14
github-actions bot pushed a commit that referenced this pull request Apr 4, 2024
## [4.10.2](v4.10.1...v4.10.2) (2024-04-04)

### Bug Fixes

* some letter are cut-off ([#284](#284)) ([948dd70](948dd70))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants