Notifications theme v2 #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverlaz
approved these changes
Jun 21, 2022
| | `--str-chat__notification-list-border-block-start` | Top border of the component | | ||
| | `--str-chat__notification-list-border-block-end` | Bottom border of the component | | ||
| | `--str-chat__notification-list-border-inline-start` | Left (right in RTL layout) border of the component | | ||
| | `--str-chat__notification-list-border-inline-start` | Right (lrft in RTL layout) border of the component | |
There was a problem hiding this comment.
Suggested change
| | `--str-chat__notification-list-border-inline-start` | Right (lrft in RTL layout) border of the component | | |
| | `--str-chat__notification-list-border-inline-end` | Right (left in RTL layout) border of the component | |
Typo
There was a problem hiding this comment.
Will fix this after the ongoing PRs merged into theming-v2
| | `--str-chat__notification-border-block-start` | Top border of the component | | ||
| | `--str-chat__notification-border-block-end` | Bottom border of the component | | ||
| | `--str-chat__notification-border-inline-start` | Left (right in RTL layout) border of the component | | ||
| | `--str-chat__notification-border-inline-start` | Right (lrft in RTL layout) border of the component | |
There was a problem hiding this comment.
Suggested change
| | `--str-chat__notification-border-inline-start` | Right (lrft in RTL layout) border of the component | | |
| | `--str-chat__notification-border-inline-end` | Right (left in RTL layout) border of the component | |
| | `--str-chat__tooltip-border-block-start` | Top border of the component | | ||
| | `--str-chat__tooltip-border-block-end` | Bottom border of the component | | ||
| | `--str-chat__tooltip-border-inline-start` | Left (right in RTL layout) border of the component | | ||
| | `--str-chat__tooltip-border-inline-start` | Right (lrft in RTL layout) border of the component | |
There was a problem hiding this comment.
Suggested change
| | `--str-chat__tooltip-border-inline-start` | Right (lrft in RTL layout) border of the component | | |
| | `--str-chat__tooltip-border-inline-end` | Right (left in RTL layout) border of the component | |
szuperaz
force-pushed
the
notifications-theme-v2
branch
from
2731412
to
9131d07
Compare
|
🎉 This PR is included in version 3.0.0-theming2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Describe why we are making this change
🛠 Implementation details
Provide a description of the implementation
🎨 UI Changes
GetStream/stream-chat-angular#314
closes #98