feat: Don't apply padding-top hack when date separator is in use #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
We have a hacky solution for applying
padding-topto the first message in the list, this is to fix the issue of reactions not displayed properly for the first message. This hack is not necessary if we have a date separator, so this PR turns that of for that cases.🛠 Implementation details
Provide a description of the implementation
🎨 UI Changes
Add relevant screenshots
Make sure to test with both Angular and React (with both
MessageListandVirtualizedMessageListcomponents) SDKs