Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(angular): make images bigger in image modal #277

Merged
merged 1 commit into from
Mar 21, 2024
Merged

fix(angular): make images bigger in image modal #277

merged 1 commit into from
Mar 21, 2024

Conversation

szuperaz
Copy link
Collaborator

🎯 Goal

This is an Angular-only change, React uses a different UI for image modals.

🛠 Implementation details

On the Angular SDK the images in the attachment modal were quite small. There were two reasons for this:

  • The layout was built in a way that didn't maximize space for images
  • We didn't have a responsive layout to make the modal bigger on mobile devices -> we generally don't provide different layouts on different devices, but I think this is one of the few places where it makes sense to add a media rule

🎨 UI Changes

Before:
IMG_3350

After:
IMG_3349

Make sure to test with both Angular and React (with both MessageList and VirtualizedMessageList components) SDKs

@szuperaz szuperaz merged commit 8a0abd1 into main Mar 21, 2024
@szuperaz szuperaz deleted the fix-image-modal branch March 21, 2024 08:21
github-actions bot pushed a commit that referenced this pull request Mar 21, 2024
@semantic-release-bot
chore(release): 4.9.2 [skip ci]
036bea7 
## [4.9.2](v4.9.1...v4.9.2) (2024-03-21)

### Bug Fixes

* **angular:** make images bigger in image modal ([#277](#277)) ([8a0abd1](8a0abd1))
* syntax for $min_amplitude_height ([#278](#278)) ([e4d2e65](e4d2e65))
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 4.9.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myandrienko myandrienko myandrienko approved these changes

@arnautov-anton arnautov-anton Awaiting requested review from arnautov-anton

@MartinCupela MartinCupela Awaiting requested review from MartinCupela

@oliverlaz oliverlaz Awaiting requested review from oliverlaz

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@szuperaz @myandrienko