Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GTM #85

Merged
merged 9 commits into from
Jul 17, 2023
Merged

Add GTM #85

merged 9 commits into from
Jul 17, 2023

Conversation

vandreleal
Copy link
Member

No description provided.

jaapbakker88
jaapbakker88 reviewed Jul 17, 2023
View reviewed changes
src/environment.js Outdated Show resolved Hide resolved
@vandreleal
Update src/environment.js
7e1a3fe 
Co-authored-by: jaapbakker88 <jaap@getstream.io>
jaapbakker88
jaapbakker88 suggested changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@jaapbakker88 jaapbakker88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One little comment but this should be good. Was looking with Rodolphe and we also figured out that GTM wasn't properly tracked, this should probably do it

@vandreleal
Copy link
Member Author

One little comment but this should be good. Was looking with Rodolphe and we also figured out that GTM wasn't properly tracked, this should probably do it

Just applied your suggestion from the previous comment.

@jaapbakker88 jaapbakker88 marked this pull request as ready for review July 17, 2023 09:49
@vandreleal vandreleal merged commit fb6d6a9 into production Jul 17, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaapbakker88 jaapbakker88 jaapbakker88 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vandreleal @jaapbakker88 @DaemonLoki @jeroenleenarts