Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): Attachment actions on full screen were broken #1076

Merged
merged 2 commits into from
Apr 13, 2022

Conversation

ayush221b
Copy link
Contributor

Submit a pull request

CLA

  • I have signed the Stream CLA (required).
  • The code changes follow best practices
  • Code changes are tested (add some information if not applicable)

Description of the pull request

Solves #1071

The FullScreen implementation and the adjoining widgets had some flaws, because of which we were getting some random unexpected behaviour. I have introduced the concept of StreamAttachmentPackage, that can be used when each individual attachment needs to be mapped to its message, I have also added a new progress UI and changed the way we track download completion for attachments. I have also made the necessary changes to the tests.

…inked to full screen implementation, also fixed tests
@ayush221b
Copy link
Contributor Author

ayush221b commented Apr 13, 2022

  1. This also removes the prefer_expression_function_bodies rule from our analysis options.
  2. Also, this exports the file src/multi_overlay.dart because that file houses the class OverlayOptions which we require when a developer has to pass customOverlays to the StreamMessageInput.

Copy link
Contributor

@imtoori imtoori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imtoori imtoori merged commit ff31f46 into v4 Apr 13, 2022
@ibhanu
Copy link

ibhanu commented May 10, 2022

fyi, it brings breaking changes!

@imtoori
Copy link
Contributor

imtoori commented May 10, 2022

@ibhanu that's why it's in v4

@ibhanu
Copy link

ibhanu commented May 10, 2022

how would it work for backward compatibility?
because old version have this issue.

@imtoori
Copy link
Contributor

imtoori commented May 10, 2022

it doesn't work :( this was the only way to fix it and we pushed it in v4 since it's breaking
I hope that's not a problem, the upgrade is not hard https://getstream.io/chat/docs/sdk/flutter/guides/migration_guide_4_0/

@xsahil03x xsahil03x deleted the fix/full_screen_media branch May 1, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants