Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for #12 #13

Merged
merged 1 commit into from Apr 7, 2020
Merged

fix for #12 #13

merged 1 commit into from Apr 7, 2020

Conversation

nosmirck
Copy link
Contributor

@nosmirck nosmirck commented Apr 6, 2020

Wrapped the TextField in a LimitedBox, gave the MessageInput a new property for that which defaults to 150p

Submit a pull request

CLA

  • I have signed the Stream CLA (required).
  • The code changes follow best practices
  • Code changes are tested (add some information if not applicable)

Attached screenshots of before and after:
BEFORE:
Simulator Screen Shot - iPhone 11 Pro Max - 2020-04-06 at 11 47 25

AFTER:
Simulator Screen Shot - iPhone 11 Pro Max - 2020-04-06 at 13 03 36
Screenshot_1586192566

Description of the pull request

@nosmirck
fix for GetStream#12
ced6f39 
Wrapped the TextField in a LimitedBox, gavethe MessageInput a new property for that which defaults to 150p
@imtoori imtoori linked an issue Apr 7, 2020 that may be closed by this pull request
MessageInput grows indefinitely #12
Closed
imtoori
imtoori approved these changes Apr 7, 2020
View reviewed changes
Copy link
Contributor

@imtoori imtoori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks nice, thank you for your contribution

@imtoori imtoori merged commit 5b2cc59 into GetStream:master Apr 7, 2020
@Okdone Okdone mentioned this pull request May 18, 2020
Closed
@rubenvereecken rubenvereecken mentioned this pull request Apr 22, 2021
Closed
6 tasks
@Nash0x7E2 Nash0x7E2 mentioned this pull request May 17, 2021
Closed
5 tasks
@poqueque poqueque mentioned this pull request Jun 17, 2021
Closed
2 tasks
@TramPamPam TramPamPam mentioned this pull request Jul 6, 2021
Closed
6 tasks
@jagged91 jagged91 mentioned this pull request Jul 9, 2021
Closed
6 tasks
@Abacaxi-Nelson Abacaxi-Nelson mentioned this pull request Apr 3, 2022
Closed
1 task
@kalptech2021 kalptech2021 mentioned this pull request May 29, 2023
Closed
1 task
@jmain20 jmain20 mentioned this pull request Oct 31, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imtoori imtoori imtoori approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MessageInput grows indefinitely
2 participants
@nosmirck @imtoori