Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MessageWidget now has user's name in the timestamp (like advertised design) #14

Merged
merged 2 commits into from
Apr 8, 2020

Conversation

nosmirck
Copy link
Contributor

@nosmirck nosmirck commented Apr 7, 2020

Submit a pull request

CLA

  • I have signed the Stream CLA (required).
  • The code changes follow best practices
  • Code changes are tested (add some information if not applicable)

Description of the pull request

Added User's name on the timestamp for the message_widget as advertised on the website

Android:
Screenshot_1586272937

iOS:
Simulator Screen Shot - iPhone 11 Pro Max - 2020-04-07 at 11 19 40

@nosmirck
Copy link
Contributor Author

nosmirck commented Apr 7, 2020

@imtoori I created this little change because I need it and I'm pretty sure more people need it too, also, it needed to match the advertised design

@nosmirck nosmirck closed this Apr 7, 2020
@nosmirck nosmirck reopened this Apr 7, 2020
@imtoori imtoori self-requested a review April 7, 2020 15:41
@imtoori imtoori self-assigned this Apr 7, 2020
@imtoori
Copy link
Contributor

imtoori commented Apr 7, 2020

Thanks, I think it's good.
Tomorrow I'll review this pr and modify it to make the name at least optional.

@imtoori imtoori added the enhancement New feature or request label Apr 7, 2020
@nosmirck
Copy link
Contributor Author

nosmirck commented Apr 7, 2020

@imtoori is there any Slack Channel you can invite me so we can coordinate better some changes on the package (like Theme #11 and time separators/grouping #10 ).

I'm implementing chat on our app (I work for Recipe Unlimited) and we need some features that are not yet available and we're glad to help.

@imtoori
Copy link
Contributor

imtoori commented Apr 7, 2020

I used your email to invite you on a Slack channel, wait for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants