-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(llc, ui): Async audio [DoNotMerge] #1486
Draft
leandroBorgesFerreira
wants to merge
153
commits into
master
Choose a base branch
from
AsyncAudio
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+3,102
−178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eed button position
leandroBorgesFerreira
force-pushed
the
AsyncAudio
branch
from
March 22, 2023 13:47
fedc4dd
to
00c27f3
Compare
…cording outside of StreamMessageInput
leandroBorgesFerreira
changed the title
feat(llc, ui): Async audio
[DoNotMerge] feat(llc, ui): Async audio
Mar 23, 2023
leandroBorgesFerreira
changed the title
[DoNotMerge] feat(llc, ui): Async audio
feat(llc, ui): Async audio [DoNotMerge]
Mar 23, 2023
leandroBorgesFerreira
force-pushed
the
AsyncAudio
branch
from
March 23, 2023 20:42
3cc53a8
to
34b4ccd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submit a pull request
CLA
Description of the pull request
This PR adds support for recorded audio messages (async audio messages).
The added functionalities to async audio messages are (Users are able to):
Screen.Recording.2023-03-16.at.21.51.50.mov
Screen.Recording.2023-03-16.at.21.52.49.mov
Screen.Recording.2023-03-16.at.21.56.25.mov
Screen.Recording.2023-03-16.at.21.56.58.mov
Implementation details
When recording, the audio bars are presented to the user and also stored in a list. After audio recording is complete normalization is done in the bars and they are presented to the users. The duration of the audio is also calculated during recording. After audio bars and duration are calculated, the audio is sent to the backend as an attachment with the type "voicenote". The duration and the bars are used when the message is displayed in the message list to present the correct UI without loading the audio file.
When the audio message doesn't have the audio bars. They are shown as a list of dots instead of the variables bars.
The audio file is streamed once "play" is pressed. So the message is only loaded when the user wants to hear it.
The wave bars are calculated from 0 to 1 and send to the backend as a list of doubles. The duration is sent to the backend in milliseconds.