Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): add support for StreamMessageListView.shrinkWrap. #1520

Merged
merged 2 commits into from
May 3, 2023

Conversation

xsahil03x
Copy link
Contributor

@xsahil03x xsahil03x commented May 3, 2023

Should be merged after #1519

Signed-off-by: xsahil03x <xdsahil@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (b4413be) 58.44% compared to head (fbf9191) 58.44%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@               Coverage Diff                @@
##           feat/update-spl    #1520   +/-   ##
================================================
  Coverage            58.44%   58.44%           
================================================
  Files                  289      289           
  Lines                17699    17700    +1     
================================================
+ Hits                 10344    10345    +1     
  Misses                7355     7355           
Impacted Files Coverage Δ
...r/lib/src/message_list_view/message_list_view.dart 45.51% <100.00%> (+0.11%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@xsahil03x xsahil03x changed the title feat(ui): update scrollable_positioned_list with the latest changes. feat(ui): add support for StreamMessageListView.shrinkWrap. May 3, 2023
Copy link
Contributor

@deven98 deven98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deven98 deven98 merged commit 80a7153 into feat/update-spl May 3, 2023
12 checks passed
@deven98 deven98 deleted the feat/message-list-view-shrink-wrap branch May 3, 2023 11:56
@xsahil03x xsahil03x mentioned this pull request May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants