Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui, core): make message input regex caseInsensitive. #1550

Merged
merged 2 commits into from
May 15, 2023

Conversation

xsahil03x
Copy link
Contributor

Fixes: #1548

Signed-off-by: xsahil03x <xdsahil@gmail.com>
Signed-off-by: xsahil03x <xdsahil@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (ee9d35b) 58.49% compared to head (a62ebcf) 58.48%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1550      +/-   ##
===========================================
- Coverage    58.49%   58.48%   -0.01%     
===========================================
  Files          290      290              
  Lines        17654    17655       +1     
===========================================
  Hits         10326    10326              
- Misses        7328     7329       +1     
Impacted Files Coverage Δ
...er/lib/src/message_input/stream_message_input.dart 35.32% <ø> (ø)
...er_core/lib/src/message_text_field_controller.dart 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@xsahil03x xsahil03x merged commit ea451b2 into develop May 15, 2023
14 checks passed
@xsahil03x xsahil03x deleted the fix/message-input-regex-case branch May 15, 2023 11:03
@xsahil03x xsahil03x mentioned this pull request Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Links are only accepted when lowercase http(s) is used.
2 participants