Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui, core): use CircularProgressIndicator.adaptive instead of material indicator. #1552

Merged
merged 2 commits into from
May 16, 2023

Conversation

xsahil03x
Copy link
Contributor

Fixes: #1540

…terial indicator.

Signed-off-by: xsahil03x <xdsahil@gmail.com>
Signed-off-by: xsahil03x <xdsahil@gmail.com>
@xsahil03x xsahil03x changed the title fix(ui, core): use CircularProgressIndicator.adaptive instead of material indicator. fix(ui, core): use CircularProgressIndicator.adaptive instead of material indicator. May 16, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 25.00% and project coverage change: -0.01 ⚠️

Comparison is base (94221ec) 58.48% compared to head (b9ce77f) 58.48%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1552      +/-   ##
===========================================
- Coverage    58.48%   58.48%   -0.01%     
===========================================
  Files          290      290              
  Lines        17656    17657       +1     
===========================================
  Hits         10326    10326              
- Misses        7330     7331       +1     
Impacted Files Coverage Δ
...at_flutter/lib/src/attachment/file_attachment.dart 48.90% <ø> (ø)
...t_flutter/lib/src/attachment/giphy_attachment.dart 22.29% <ø> (ø)
...chment_actions_modal/attachment_actions_modal.dart 48.75% <0.00%> (-0.31%) ⬇️
...eam_chat_flutter/lib/src/channel/channel_info.dart 82.08% <ø> (ø)
...t_flutter/lib/src/channel/channel_list_header.dart 95.50% <ø> (ø)
...er/lib/src/fullscreen_media/full_screen_media.dart 42.43% <ø> (ø)
...r/lib/src/message_input/quoted_message_widget.dart 0.00% <ø> (ø)
...r/lib/src/message_list_view/loading_indicator.dart 61.53% <ø> (ø)
...r/lib/src/message_list_view/message_list_view.dart 44.82% <ø> (ø)
...m_chat_flutter_core/lib/src/message_list_core.dart 82.60% <ø> (ø)
... and 2 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@xsahil03x xsahil03x merged commit 6081f25 into develop May 16, 2023
14 of 16 checks passed
@xsahil03x xsahil03x deleted the fix/progress-indicator branch May 16, 2023 11:01
@xsahil03x xsahil03x mentioned this pull request Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StreamChannel widgets uses Material loading UI for iOS also
2 participants