refactor!(ui, llc): Attachments refactor. #1667

xsahil03x · 2023-07-11T10:27:23Z

Before	After
Screen.Recording.2023-07-11.at.3.59.26.PM.mov	New.Attachments.mov

codecov-commenter · 2023-07-26T22:03:14Z

Codecov Report

Patch coverage: 38.70% and project coverage change: +0.07% 🎉

Comparison is base (0e93e12) 58.47% compared to head (eeb957f) 58.55%.
Report is 35 commits behind head on v7.0.0.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files

@@            Coverage Diff             @@
##           v7.0.0    #1667      +/-   ##
==========================================
+ Coverage   58.47%   58.55%   +0.07%     
==========================================
  Files         290      310      +20     
  Lines       17652    17772     +120     
==========================================
+ Hits        10322    10406      +84     
- Misses       7330     7366      +36

Files Changed	Coverage Δ
packages/stream_chat/lib/src/client/client.dart	`88.77% <ø> (ø)`
...kages/stream_chat/lib/src/client/retry_policy.dart	`100.00% <ø> (ø)`
...ackages/stream_chat/lib/src/core/api/requests.dart	`86.84% <ø> (ø)`
...eam_chat/lib/src/core/error/stream_chat_error.dart	`87.03% <ø> (ø)`
...hat/lib/src/core/models/attachment_giphy_info.dart	`0.00% <0.00%> (ø)`
...ckages/stream_chat/lib/src/core/models/member.dart	`61.11% <ø> (ø)`
...tream_chat/lib/src/db/chat_persistence_client.dart	`91.26% <ø> (ø)`
packages/stream_chat/lib/src/ws/timer_helper.dart	`100.00% <ø> (ø)`
...rc/attachment/attachment_upload_state_builder.dart	`20.73% <ø> (ø)`
.../lib/src/attachment/attachment_widget_catalog.dart	`0.00% <0.00%> (ø)`
... and 93 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: xsahil03x <xdsahil@gmail.com>

kanat · 2023-07-28T18:14:11Z

packages/stream_chat/lib/src/core/models/attachment.dart

+    // If the attachment contains titleLink but is not of type giphy, we
+    // consider it as a urlPreview.


This comment just duplicates the code below.
Could we put the reason why we're doing this instead (why we consider it as urlPreview)? 🙂

kanat · 2023-07-28T18:23:10Z

packages/stream_chat/lib/src/core/models/attachment_file.dart

-  MediaType? get mimeType => name?.mimeType;
+  MediaType? get mediaType => name?.mediaType;


Is this a breaking change?
Should we do the deprecation cycle before replacing it with mediaType?

kanat · 2023-07-28T18:24:27Z

packages/stream_chat/lib/src/core/models/attachment_giphy_info.dart

+/// {@template giphy_info}
+/// A class that contains extra information about a Giphy attachment.
+/// {@endtemplate}
+class GiphyInfo {


Just curious if need Equatable here.

not needed. Used just to store some values.

kanat · 2023-07-28T18:26:54Z

packages/stream_chat/lib/src/core/models/attachment_giphy_info.dart

+extension GiphyInfoX on Attachment {
+  /// Returns the [GiphyInfo] for the given [type].
+  GiphyInfo? giphyInfo(GiphyInfoType type) {
+    final giphy = extraData['giphy'] as Map<String, Object?>?;


Could we extract 'giphy' as shared const or enum?
Is this the only place where we use hardcoded 'giphy' value?

kanat · 2023-07-28T18:32:44Z

packages/stream_chat_flutter/lib/src/attachment/attachment_title.dart

Is this a breaking change?
It looks like this was an exported class.

kanat · 2023-07-28T18:59:09Z

packages/stream_chat_flutter/lib/src/message_input/stream_message_input_attachment_list.dart

@@ -256,7 +251,8 @@ class MessageInputMediaAttachments extends StatelessWidget {
      height: 104,
      child: ListView(
        scrollDirection: Axis.horizontal,
-        padding: const EdgeInsets.symmetric(horizontal: 8),
+        padding: const EdgeInsets.symmetric(vertical: 2, horizontal: 8),
+        cacheExtent: 104 * 10, // Cache 10 items ahead.


Curious where the magic number 104 comes from

figma design

kanat · 2023-07-28T19:00:47Z

packages/stream_chat_flutter/lib/src/message_input/stream_message_input_attachment_list.dart

Is it a breaking change?

kanat · 2023-07-28T20:11:55Z

packages/stream_chat_flutter/lib/src/message_widget/message_widget.dart

+  // attachmentBuilders = {
+  //   // Add all default builders
+  //   'image': (context, message, attachments) {
+  //     final color = StreamChatTheme.of(context).colorTheme.borders;
+  //     final border = RoundedRectangleBorder(
+  //       side: attachmentBorderSide ?? BorderSide(color: color),
+  //       borderRadius: attachmentBorderRadiusGeometry ?? BorderRadius.zero,
+  //     );
+  //
+  //     if (attachments.length > 1) {
+  //       return WrapAttachmentWidget(
+  //         attachmentShape: border,
+  //         attachmentWidget: Material(


Do we still need this commented out section?

kanat · 2023-07-28T20:13:04Z

packages/stream_chat_flutter/lib/src/message_widget/message_widget.dart

-    this.attachmentShape,
    this.borderSide,
-    this.attachmentBorderSide,
    this.borderRadiusGeometry,
-    this.attachmentBorderRadiusGeometry,
+    this.attachmentShape,


Possible breaking change?

kanat · 2023-07-28T20:14:46Z

packages/stream_chat_flutter/lib/src/video/video_thumbnail_image.dart

+    required this.video,
+    this.headers,
+    this.imageFormat = ImageFormat.PNG,
+    this.maxHeight = 0,
+    this.maxWidth = 0,
+    this.timeMs = 0,
+    this.quality = 10,
+    this.scale = 1.0,


Seems like a breaking change as well.

xsahil03x · 2023-08-03T09:13:49Z

@kanat yes, this PR will be part of V7 of the SDK. We need to write migration guides and docs along with it.

# Conflicts: # packages/stream_chat_flutter/lib/src/fullscreen_media/full_screen_media.dart # packages/stream_chat_flutter/lib/src/fullscreen_media/full_screen_media_desktop.dart # packages/stream_chat_flutter/pubspec.yaml

Signed-off-by: Sahil Kumar <xdsahil@gmail.com>

kanat

LGTM

xsahil03x linked an issue Jul 11, 2023 that may be closed by this pull request

urlAttachmentBackgroundColor applies to whole message instead of just url attachment part #1545

Closed

1 task

xsahil03x changed the base branch from develop to v7.0.0 July 12, 2023 10:08

xsahil03x force-pushed the refactor/attachments branch from ce90e0f to 4699e65 Compare July 13, 2023 11:11

xsahil03x force-pushed the v7.0.0 branch from b8eeb2d to 6af3aaa Compare July 18, 2023 11:05

xsahil03x force-pushed the refactor/attachments branch from 9750ddd to bd1bf0a Compare July 26, 2023 10:49

xsahil03x marked this pull request as ready for review July 26, 2023 20:38

xsahil03x added 7 commits July 28, 2023 21:07

refactor!: initial attachments refactor.

f246de5

Signed-off-by: xsahil03x <xdsahil@gmail.com>

feat: more implementation.

e8de288

Signed-off-by: xsahil03x <xdsahil@gmail.com>

test: fix test.

b2171b5

Signed-off-by: xsahil03x <xdsahil@gmail.com>

test: fix more test.

db6febc

Signed-off-by: xsahil03x <xdsahil@gmail.com>

test: some more test.

572207c

Signed-off-by: xsahil03x <xdsahil@gmail.com>

refactor: improve fullscreen_media, minor changes.

93b4158

Signed-off-by: xsahil03x <xdsahil@gmail.com>

chore: fix lints.

72e0c7b

Signed-off-by: xsahil03x <xdsahil@gmail.com>

xsahil03x force-pushed the refactor/attachments branch from 318b0b3 to 72e0c7b Compare July 28, 2023 15:37

fix: fix test.

ff3ad6b

Signed-off-by: xsahil03x <xdsahil@gmail.com>

xsahil03x requested review from deven98 and kanat July 28, 2023 17:58

xsahil03x changed the title ~~refactor!(ui): Attachments refactor.~~ refactor!(ui, llc): Attachments refactor. Jul 28, 2023

xsahil03x added 2 commits July 29, 2023 00:12

chore: minor ui fixes.

795c494

Signed-off-by: xsahil03x <xdsahil@gmail.com>

chore: fix formatting.

eeb957f

Signed-off-by: xsahil03x <xdsahil@gmail.com>

kanat reviewed Jul 28, 2023

View reviewed changes

xsahil03x added 2 commits August 18, 2023 19:47

chore: fix lints.

9f4c31c

Signed-off-by: Sahil Kumar <xdsahil@gmail.com>

kanat approved these changes Sep 1, 2023

View reviewed changes

xsahil03x merged commit 687475b into v7.0.0 Sep 7, 2023
6 checks passed

xsahil03x deleted the refactor/attachments branch September 7, 2023 10:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor!(ui, llc): Attachments refactor. #1667

refactor!(ui, llc): Attachments refactor. #1667

xsahil03x commented Jul 11, 2023 •

edited

Loading

codecov-commenter commented Jul 26, 2023 •

edited

Loading

kanat Jul 28, 2023

kanat Jul 28, 2023

kanat Jul 28, 2023

xsahil03x Aug 7, 2023

kanat Jul 28, 2023

kanat Jul 28, 2023

kanat Jul 28, 2023

xsahil03x Aug 7, 2023

kanat Jul 28, 2023

kanat Jul 28, 2023

kanat Jul 28, 2023

kanat Jul 28, 2023

xsahil03x commented Aug 3, 2023

kanat left a comment

		// If the attachment contains titleLink but is not of type giphy, we
		// consider it as a urlPreview.

		MediaType? get mimeType => name?.mimeType;
		MediaType? get mediaType => name?.mediaType;

refactor!(ui, llc): Attachments refactor. #1667

refactor!(ui, llc): Attachments refactor. #1667

Conversation

xsahil03x commented Jul 11, 2023 • edited Loading

codecov-commenter commented Jul 26, 2023 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xsahil03x commented Aug 3, 2023

kanat left a comment

Choose a reason for hiding this comment

xsahil03x commented Jul 11, 2023 •

edited

Loading

codecov-commenter commented Jul 26, 2023 •

edited

Loading