Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): fix video_player:macos multiple possible implementations. #1741

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

xsahil03x
Copy link
Contributor

Fixes: #1740

Signed-off-by: Sahil Kumar <xdsahil@gmail.com>
@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (d10d545) 58.30% compared to head (62b59f8) 58.30%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1741   +/-   ##
========================================
  Coverage    58.30%   58.30%           
========================================
  Files          292      292           
  Lines        18010    18010           
========================================
  Hits         10500    10500           
  Misses        7510     7510           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xsahil03x xsahil03x merged commit a730fe6 into develop Oct 2, 2023
9 checks passed
@xsahil03x xsahil03x deleted the fix/video_player_macos_impl branch October 2, 2023 09:42
@xsahil03x xsahil03x mentioned this pull request Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New project using Flutter SDK 3 would generate error when running in iOS simulator
2 participants