fix(ui): deprecate exposed showReactionPickerTail in MessageWidget
#1762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esarbanis
changed the title
showReactionPickerTail in MessageWidgetshowReactionPickerTail in MessageWidget
esarbanis
force-pushed
the
fix/1759
branch
3 times, most recently
from
a03faa2
to
4f0049d
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #1762 +/- ##
===========================================
+ Coverage 58.30% 58.82% +0.52%
===========================================
Files 292 292
Lines 18010 18009 -1
===========================================
+ Hits 10500 10594 +94
+ Misses 7510 7415 -95
☔ View full report in Codecov by Sentry. |
deven98
reviewed
Nov 2, 2023
`showReactionPickerTail` property is bind with `showReactionPicker` as it is the only one needed to couple the reaction modal with the tail Closes #1759
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submit a pull request
CLA
Description of the pull request
showReactionPickerTailproperty is bind withshowReactionPickeras it is the only one needed to couple the reaction modal with the tail.Closes #1759