Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(llc): delete image and file attachments from the CDN, when the message get's deleted #1842

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

esarbanis
Copy link
Contributor

@esarbanis esarbanis commented Feb 2, 2024

Submit a pull request

CLA

  • I have signed the Stream CLA (required).
  • The code changes follow best practices
  • Code changes are tested (add some information if not applicable)

Description of the pull request

Closes #1837

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5559339) 59.14% compared to head (1ed0a98) 59.16%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1842      +/-   ##
==========================================
+ Coverage   59.14%   59.16%   +0.01%     
==========================================
  Files         310      310              
  Lines       17798    17804       +6     
==========================================
+ Hits        10527    10534       +7     
+ Misses       7271     7270       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Brazol
Brazol previously approved these changes Feb 2, 2024
Copy link
Contributor

@Brazol Brazol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@esarbanis esarbanis merged commit 1d1acdc into master Feb 2, 2024
16 checks passed
@esarbanis esarbanis deleted the fix/gh-1837 branch February 5, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deleting image message does not call delete the image from backend
2 participants