Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(repo): make stable version compatible with latest flutter versions #1870

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

esarbanis
Copy link
Contributor

Submit a pull request

CLA

  • I have signed the Stream CLA (required).
  • The code changes follow best practices
  • Code changes are tested (add some information if not applicable)

Description of the pull request

These changes will make main compatible with Flutter >= 3.16.0

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 93.10345% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 59.41%. Comparing base (226933c) to head (f859d97).

Files Patch % Lines
...ottom_sheets/stream_channel_info_bottom_sheet.dart 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1870   +/-   ##
=======================================
  Coverage   59.40%   59.41%           
=======================================
  Files         310      310           
  Lines       17834    17837    +3     
=======================================
+ Hits        10594    10597    +3     
  Misses       7240     7240           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

README.md Show resolved Hide resolved
Brazol
Brazol previously approved these changes Mar 6, 2024
Copy link
Contributor

@Brazol Brazol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@esarbanis esarbanis merged commit 590b6f0 into master Mar 6, 2024
16 checks passed
@esarbanis esarbanis deleted the chore/tests branch March 6, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants